Core: Improve internal types#23632
Merged
Merged
Conversation
JReinhold
requested review from
ndelangen,
shilman,
tmeasday and
yannbf
as code owners
shilman
reviewed
Jul 27, 2023
shilman
left a comment
shilman
left a comment
Member
There was a problem hiding this comment.
@JReinhold I don't think this is going to work unless you also fixed the code path that throws a non-error. I never really understood this error code. Perhaps @tmeasday or @ndelangen has more context
JReinhold
added
maintenance
Contributor
Author
|
It's a bit of a convenience @kasperpeulen and I came up with. The current code and the changes here assumes that everyone is always throwing an error, and never something else. We feel that's a fair assumption, being able to throw anything but an error feels like a bug in the language. This convenient change just means that you don't have to convert your |
5 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
While merging
nextand #23182 into this branch, @kasperpeulen and I noticed some typing stuff we wanted to improve, so we did that here.@shilman you want to notice the changes to the telemetry logic:
sendTelemetryErrorsupportunknownparameter, so you don't have to check the caught error being an instanceof error every time, you can just pass it in.How to test
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>